Skip to content

feat(router): Add the target RouterStateSnapshot to NavigationError #46731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atscott wants to merge 1 commit into from
Closed

feat(router): Add the target RouterStateSnapshot to NavigationError #46731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion goldens/public-api/router/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,11 @@ export class NavigationError extends RouterEvent {
constructor(
id: number,
url: string,
error: any);
error: any,
target?: RouterStateSnapshot | undefined);
// (undocumented)
error: any;
readonly target?: RouterStateSnapshot | undefined;
// (undocumented)
toString(): string;
// (undocumented)
Expand Down
9 changes: 8 additions & 1 deletion packages/router/src/events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,14 @@ export class NavigationError extends RouterEvent {
/** @docsNotRequired */
url: string,
/** @docsNotRequired */
public error: any) {
public error: any,
/**
* The target of the navigation when the error occurred.
*
* Note that this can be `undefined` because an error could have occurred before the
* `RouterStateSnapshot` was created for the navigation.
*/
readonly target?: RouterStateSnapshot) {
super(id, url);
}

Expand Down
5 changes: 3 additions & 2 deletions packages/router/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,8 +970,9 @@ export class Router {
* the pre-error state. */
} else {
this.restoreHistory(t, true);
const navError =
new NavigationError(t.id, this.serializeUrl(t.extractedUrl), e);
const navError = new NavigationError(
t.id, this.serializeUrl(t.extractedUrl), e,
t.targetSnapshot ?? undefined);
eventsSubject.next(navError);
try {
t.resolve(this.errorHandler(e));
Expand Down