refactor(core): NgModuleRef should not implement EnvironmentInjector interface#46896
Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Closed
refactor(core): NgModuleRef should not implement EnvironmentInjector interface#46896AndrewKushnir wants to merge 2 commits intoangular:mainfrom
NgModuleRef should not implement EnvironmentInjector interface#46896AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Conversation
…ular#46877)" This reverts commit 14081dc.
…interface This commit refactors the `NgModuleRef` implementation to drop functions required by the `EnvironmentInjector` interface. Previously the idea was that the `NgModuleRef` can act as an Injector to facilitate easier transition to standalone. However, from the mental model perspective, the `NgModuleRef` has the `injector` field, which is the correct injector reference and can be used is needed as an `EnvironmentInjector`.
1dad92c to
fca66f5
Compare
Contributor
Author
|
Presubmit (note: this change would also need a TGP). |
atscott
approved these changes
Jul 19, 2022
Contributor
Author
Contributor
Author
|
This PR was merged into the repository by commit 7a6509b. |
AndrewKushnir
added a commit
that referenced
this pull request
Jul 20, 2022
…interface (#46896) This commit refactors the `NgModuleRef` implementation to drop functions required by the `EnvironmentInjector` interface. Previously the idea was that the `NgModuleRef` can act as an Injector to facilitate easier transition to standalone. However, from the mental model perspective, the `NgModuleRef` has the `injector` field, which is the correct injector reference and can be used is needed as an `EnvironmentInjector`. PR Close #46896
AndrewKushnir
added a commit
that referenced
this pull request
Jul 20, 2022
…interface (#46896) This commit refactors the `NgModuleRef` implementation to drop functions required by the `EnvironmentInjector` interface. Previously the idea was that the `NgModuleRef` can act as an Injector to facilitate easier transition to standalone. However, from the mental model perspective, the `NgModuleRef` has the `injector` field, which is the correct injector reference and can be used is needed as an `EnvironmentInjector`. PR Close #46896
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the
NgModuleRefimplementation to drop functions required by theEnvironmentInjectorinterface. Previously the idea was that theNgModuleRefcan act as an Injector to facilitate easier transition to standalone. However, from the mental model perspective, theNgModuleRefhas theinjectorfield, which is the correct injector reference and can be used is needed as anEnvironmentInjector.PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?