Skip to content

Comments

feat(cli): Adding support for custom uglify options in .angular-cli.json#5192

Closed
jgodi wants to merge 2 commits intoangular:masterfrom
jgodi:master
Closed

feat(cli): Adding support for custom uglify options in .angular-cli.json#5192
jgodi wants to merge 2 commits intoangular:masterfrom
jgodi:master

Conversation

@jgodi
Copy link

@jgodi jgodi commented Mar 2, 2017

Description

Adding an option into the .angular-cli.json to provide custom options to the UglifyJsPlugin that is used for production builds.

Why?

We are using some older libraries inside our Angular application that when we build for production we require the compress: { keep_fnames: true } on the UglifyJsPlugin plugin. The CLI does not currently support this, so I added a way to pass any options to the UglifyJsPlugin.

The .angular-cli.json can now have the following property:

"apps": [{
    "uglifyOptions": {
        "mangle": {
            "keep_fnames": true
        }
    }
}]

Then this will just merge the already defaulted options that were there with any new options that the user needs or wants.

This issue was brought up and closed in a few PRs and tickets, but there was never a solution. (#1662 & #3167)

@Brocco
Copy link
Contributor

Brocco commented Mar 3, 2017

Thank you for putting in the time for this PR. However the CLI's current approach to build customization is via the eject option (ng eject) which will give users full control over the build process.

There are plans in the future to allow incremental changes to the existing build process without having to eject but that level of granularity is not ready yet.

@Brocco Brocco closed this Mar 3, 2017
@dkamburov dkamburov mentioned this pull request Mar 28, 2017
Closed
@jgodi jgodi mentioned this pull request Jun 17, 2017
Closed
@udos86 udos86 mentioned this pull request Jun 30, 2017
Closed
@nschipperbrainsmith
Copy link

nschipperbrainsmith commented Jul 10, 2018

@Brocco is this still the way to go about it by ejecting the full config in case I wish to modify the mangle keep_fnames option within the models/webpack-configs/production.js ? I would love to be able to simply change that one option to say don't mangle my names.

@bd82 bd82 mentioned this pull request Apr 23, 2019
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jgodi @Brocco @nschipperbrainsmith @googlebot