Replaced Sortable with ng-sortable#166
Open
bojanbass wants to merge 3 commits intoangular-dashboard-framework:masterfrom
Open
Replaced Sortable with ng-sortable#166bojanbass wants to merge 3 commits intoangular-dashboard-framework:masterfrom
bojanbass wants to merge 3 commits intoangular-dashboard-framework:masterfrom
Conversation
replaced Sortable with ng-sortable wrapper changed sample to use ng-sortable
Member
|
We had some problems with ng-sortable, during the drag and drop implementation with sortable (in particular with deactivated debug mode). It looks that the debug mode problem is fixed (#255). We have todo some tests and we have to fix the unit tests, but i think it is a great idea to replace the drag and drop code with the ng-sortable directive. |
Member
|
I've done some tests with the samples and i got a lot of issues: |
Author
|
Could you tell me which actions caused these errors? Also I forgot to fix unit tests. |
Add dependencies.yml for dependencies.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I made a replacement inside column directive to use ng-sortable angular wrapper for Sortable library. I removed a lot of unused code from column directive this way. Please check, if it makes sense to use this one in your framework. A downside is that we have to include a new js library ng-sortable.js and inject it as angular dependency at startup. I also fixed the sample code to work with these changes.
Regards.