Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12652 +/- ##
============================================
+ Coverage 17.89% 17.94% +0.04%
- Complexity 16092 16164 +72
============================================
Files 5936 5939 +3
Lines 532734 533015 +281
Branches 65165 65218 +53
============================================
+ Hits 95347 95649 +302
+ Misses 426711 426638 -73
- Partials 10676 10728 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR experiments with adopting the gh-aw agentic workflow setup by adding two generated agent workflows (and their source manifests) plus repository configuration changes to avoid conflicts with existing license/RAT and pre-commit checks.
Changes:
- Add
gh-awworkflow manifests (*.md) and compiled workflow lock files (*.lock.yml) for issue triage and daily repo status. - Adjust pre-commit exclusions to avoid auto-inserting license headers / linting generated workflow artifacts.
- Update RAT exclusions and add
.gitattributesrules for generated workflow lock files and cached imports.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Updates Apache RAT excludes to ignore new agentic-workflow related files. |
.pre-commit-config.yaml |
Extends hook exclude patterns to skip workflow markdown and generated lock files. |
.github/workflows/issue-triage-agent.md |
Adds the gh-aw workflow manifest for issue triage agent behavior. |
.github/workflows/issue-triage-agent.lock.yml |
Adds compiled GitHub Actions workflow generated by gh-aw for issue triage. |
.github/workflows/daily-repo-status.md |
Adds the gh-aw workflow manifest for daily repo status reporting. |
.github/workflows/daily-repo-status.lock.yml |
Adds compiled GitHub Actions workflow generated by gh-aw for daily repo status. |
.github/aw/imports/github/gh-aw/.../.github_workflows_shared_reporting.md |
Adds cached imported shared reporting guidelines used by gh-aw manifests. |
.github/aw/imports/.gitattributes |
Marks cached imports as generated and sets merge strategy for updates. |
.gitattributes |
Marks workflow lock files as generated and uses merge=ours for them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <exclude>**/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker</exclude> | ||
| <exclude>.github/workflows/dependabot.yaml</exclude> | ||
| <exclude>.github/workflows/*.md</exclude> | ||
| <exclude>.github/workflows/*.lock.md</exclude> |
There was a problem hiding this comment.
The RAT plugin exclude list adds .github/workflows/*.lock.md, but the generated workflows in this PR are .github/workflows/*.lock.yml. As-is, RAT will still scan the new lock files (which don’t contain ASF headers) and likely fail the build. Update the excludes to match *.lock.yml (and consider excluding all *.lock.ya?ml if both extensions are possible).
| <exclude>.github/workflows/*.lock.md</exclude> | |
| <exclude>.github/workflows/*.lock.md</exclude> | |
| <exclude>.github/workflows/*.lock.ya?ml</exclude> |
| @@ -0,0 +1 @@ | |||
| .github/workflows/*.lock.yml linguist-generated=true merge=ours | |||
There was a problem hiding this comment.
This new .gitattributes file does not include the standard ASF license header used in other repo root config files, which may cause the RAT license check to fail. Add the ASF header (as # comments) or explicitly exclude .gitattributes from the RAT plugin configuration.
| types: [yaml] | ||
| files: \.ya?ml$ | ||
| exclude: ^.*k8s-.*\.ya?ml$ | ||
| exclude: ^.*k8s-.*\.ya?ml$|^.github/workflows/daily-repo-status\.lock\.ya?ml$|^.github/workflows/issue-triage-agent.lock.yml$ |
There was a problem hiding this comment.
The yamllint hook’s exclude regex uses |^.github/... (dot not escaped), so it will also match paths like xgithub/... unintentionally. Escape the leading dot (^\.github/...) for both added patterns to avoid excluding non-workflow YAML files by accident.
| exclude: ^.*k8s-.*\.ya?ml$|^.github/workflows/daily-repo-status\.lock\.ya?ml$|^.github/workflows/issue-triage-agent.lock.yml$ | |
| exclude: ^.*k8s-.*\.ya?ml$|^\.github/workflows/daily-repo-status\.lock\.ya?ml$|^\.github/workflows/issue-triage-agent.lock.yml$ |
Description
This PR to try-out https://github.github.com/gh-aw/setup/quick-start/
install wizard conflicts with out pre-commit rules so this PR
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?