feat: appwrite agent skills #11285
Open
feat: appwrite agent skills #11285
+198
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ✏️ Tip: You can disable in-progress messages and the fortune message in your review settings. 📝 WalkthroughWalkthroughThe pull request adds an AgentSkills SDK: a new entry in app/config/sdks.php with metadata (key, name, version, URLs, git fields, flags, family, prism, changelog); updates composer.json require-dev for appwrite/sdk-generator from "*" to "dev-feat/agent-skills"; and integrates AgentSkills into SDK generation by importing Appwrite\SDK\Language\AgentSkills, adding 'agent-skills' to the supported SDKs list, and handling it in the SDKs task switch. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
919eb70 to
934f7ea
Compare
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@app/config/sdks.php`:
- Around line 273-291: Update the SDK entry so the repository is under the
appwrite organization and the config fields match other SDK entries: set
gitUserName to "appwrite" and update gitUrl/gitRepoName accordingly (e.g.,
gitUrl -> git@github.com:appwrite/appwrite-agent-skills.git), change url to the
browseable URL without the ".git" suffix (e.g.,
https://github.com/appwrite/appwrite-agent-skills), and add a package key (even
if an empty string) to the array; ensure the actual GitHub repo is
created/transferred to the appwrite org before merging and leave other keys like
source and changelog unchanged.
In `@composer.json`:
- Line 92: The composer.json currently pins the dev dependency
"appwrite/sdk-generator" to the feature branch "dev-feat/agent-skills"; update
that constraint to a non-feature ref before merging (e.g., change to a tagged
release version or "dev-main" once AgentSkills is merged) by modifying the
"appwrite/sdk-generator" entry in composer.json to the appropriate stable/tagged
version or dev-main instead of dev-feat/agent-skills.
In `@src/Appwrite/Platform/Tasks/SDKs.php`:
- Line 24: Move the Appwrite\SDK\Language\AgentSkills import so imports are
alphabetically ordered to satisfy PSR-12; specifically place the "use
Appwrite\SDK\Language\AgentSkills;" line before the "use
Appwrite\SDK\Language\Android;" import in the SDKs.php import block so
AgentSkills sorts correctly among the other SDK language imports.
Comment on lines
273
to
291
| [ | ||
| 'key' => 'agent-skills', | ||
| 'name' => 'AgentSkills', | ||
| 'version' => '0.1.0', | ||
| 'url' => 'https://github.com/ChiragAgg5k/appwrite-agent-skills.git', | ||
| 'enabled' => true, | ||
| 'beta' => false, | ||
| 'dev' => false, | ||
| 'hidden' => false, | ||
| 'family' => APP_SDK_PLATFORM_CONSOLE, | ||
| 'prism' => 'agent-skills', | ||
| 'source' => \realpath(__DIR__ . '/../sdks/console-agent-skills'), | ||
| 'gitUrl' => 'git@github.com:ChiragAgg5k/appwrite-agent-skills.git', | ||
| 'gitRepoName' => 'appwrite-agent-skills', | ||
| 'gitUserName' => 'ChiragAgg5k', | ||
| 'gitBranch' => 'dev', | ||
| 'repoBranch' => 'master', | ||
| 'changelog' => \realpath(__DIR__ . '/../../docs/sdks/agent-skills/CHANGELOG.md'), | ||
| ], |
Contributor
There was a problem hiding this comment.
Repository should be under the appwrite organization, not a personal account.
All other SDKs use appwrite as the gitUserName and host repos under the appwrite org. This entry points to ChiragAgg5k/appwrite-agent-skills — ensure the repo is transferred to (or created under) the appwrite org before merging to 1.8.x.
Additionally:
urlhas a.gitsuffix — other SDK entries use clean browseable URLs (e.g.,https://github.com/appwrite/sdk-for-web). Remove the.gitsuffix for consistency.- Missing
packagekey — every other SDK entry includes apackagefield. Add it (even if empty string) to stay consistent and avoid potentialundefined indexissues downstream.
Suggested adjustments
[
'key' => 'agent-skills',
'name' => 'AgentSkills',
'version' => '0.1.0',
- 'url' => 'https://github.com/ChiragAgg5k/appwrite-agent-skills.git',
+ 'url' => 'https://github.com/appwrite/sdk-for-agent-skills',
+ 'package' => '',
'enabled' => true,
'beta' => false,
'dev' => false,
'hidden' => false,
'family' => APP_SDK_PLATFORM_CONSOLE,
'prism' => 'agent-skills',
'source' => \realpath(__DIR__ . '/../sdks/console-agent-skills'),
- 'gitUrl' => 'git@github.com:ChiragAgg5k/appwrite-agent-skills.git',
- 'gitRepoName' => 'appwrite-agent-skills',
- 'gitUserName' => 'ChiragAgg5k',
+ 'gitUrl' => 'git@github.com:appwrite/sdk-for-agent-skills.git',
+ 'gitRepoName' => 'sdk-for-agent-skills',
+ 'gitUserName' => 'appwrite',
'gitBranch' => 'dev',
'repoBranch' => 'master',
'changelog' => \realpath(__DIR__ . '/../../docs/sdks/agent-skills/CHANGELOG.md'),
],📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| [ | |
| 'key' => 'agent-skills', | |
| 'name' => 'AgentSkills', | |
| 'version' => '0.1.0', | |
| 'url' => 'https://github.com/ChiragAgg5k/appwrite-agent-skills.git', | |
| 'enabled' => true, | |
| 'beta' => false, | |
| 'dev' => false, | |
| 'hidden' => false, | |
| 'family' => APP_SDK_PLATFORM_CONSOLE, | |
| 'prism' => 'agent-skills', | |
| 'source' => \realpath(__DIR__ . '/../sdks/console-agent-skills'), | |
| 'gitUrl' => 'git@github.com:ChiragAgg5k/appwrite-agent-skills.git', | |
| 'gitRepoName' => 'appwrite-agent-skills', | |
| 'gitUserName' => 'ChiragAgg5k', | |
| 'gitBranch' => 'dev', | |
| 'repoBranch' => 'master', | |
| 'changelog' => \realpath(__DIR__ . '/../../docs/sdks/agent-skills/CHANGELOG.md'), | |
| ], | |
| [ | |
| 'key' => 'agent-skills', | |
| 'name' => 'AgentSkills', | |
| 'version' => '0.1.0', | |
| 'url' => 'https://github.com/appwrite/sdk-for-agent-skills', | |
| 'package' => '', | |
| 'enabled' => true, | |
| 'beta' => false, | |
| 'dev' => false, | |
| 'hidden' => false, | |
| 'family' => APP_SDK_PLATFORM_CONSOLE, | |
| 'prism' => 'agent-skills', | |
| 'source' => \realpath(__DIR__ . '/../sdks/console-agent-skills'), | |
| 'gitUrl' => 'git@github.com:appwrite/sdk-for-agent-skills.git', | |
| 'gitRepoName' => 'sdk-for-agent-skills', | |
| 'gitUserName' => 'appwrite', | |
| 'gitBranch' => 'dev', | |
| 'repoBranch' => 'master', | |
| 'changelog' => \realpath(__DIR__ . '/../../docs/sdks/agent-skills/CHANGELOG.md'), | |
| ], |
🤖 Prompt for AI Agents
In `@app/config/sdks.php` around lines 273 - 291, Update the SDK entry so the
repository is under the appwrite organization and the config fields match other
SDK entries: set gitUserName to "appwrite" and update gitUrl/gitRepoName
accordingly (e.g., gitUrl -> git@github.com:appwrite/appwrite-agent-skills.git),
change url to the browseable URL without the ".git" suffix (e.g.,
https://github.com/appwrite/appwrite-agent-skills), and add a package key (even
if an empty string) to the array; ensure the actual GitHub repo is
created/transferred to the appwrite org before merging and leave other keys like
source and changelog unchanged.
| "require-dev": { | ||
| "ext-fileinfo": "*", | ||
| "appwrite/sdk-generator": "*", | ||
| "appwrite/sdk-generator": "dev-feat/agent-skills", |
Contributor
There was a problem hiding this comment.
Dev dependency pinned to a feature branch — must be reverted before merge.
Pinning appwrite/sdk-generator to dev-feat/agent-skills is fine during development, but this should not be merged into 1.8.x. Once the AgentSkills language class is available in a tagged release (or at minimum dev-main), update the constraint accordingly.
🤖 Prompt for AI Agents
In `@composer.json` at line 92, The composer.json currently pins the dev
dependency "appwrite/sdk-generator" to the feature branch
"dev-feat/agent-skills"; update that constraint to a non-feature ref before
merging (e.g., change to a tagged release version or "dev-main" once AgentSkills
is merged) by modifying the "appwrite/sdk-generator" entry in composer.json to
the appropriate stable/tagged version or dev-main instead of
dev-feat/agent-skills.
✨ Benchmark results
⚡ Benchmark Comparison
|
934f7ea to
17d3abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.