fix: allow webhooks with IP addresses and private domains #11301
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove PublicDomain validator from webhook URL validation in both createWebhook and updateWebhook endpoints. The URL validator already validates URL structure. PublicDomain rejected IP addresses like http://192.168.1.16:24040/sync which are valid for self-hosted users.
Contributor
📝 WalkthroughWalkthroughThis change removes the PublicDomain validator from webhook URL validation in the API endpoints. The URL parameter validation for both webhook creation and update endpoints is simplified from a composite validation (checking URL validity and public domain status) to a single URL validator that only ensures http or https schemes. Two corresponding test cases are updated to reflect that webhook operations with private domains and IP addresses now succeed instead of returning 400 status codes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the restriction that prevented Webhooks from using IP addresses or private domains (like ), which is a common requirement for self-hosted instances. Updated tests to assert success for private IPs. Fixes #7989.