Skip to content

Basic workspace support#1194

Merged
g-r-a-n-t merged 2 commits intoargotorg:masterfrom
g-r-a-n-t:workspace
Jan 28, 2026
Merged

Basic workspace support#1194
g-r-a-n-t merged 2 commits intoargotorg:masterfrom
g-r-a-n-t:workspace

Conversation

@g-r-a-n-t
Copy link
Collaborator

@g-r-a-n-t g-r-a-n-t commented Dec 22, 2025 •
edited
Loading

Adds support for ingot workspaces.

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Dec 22, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@g-r-a-n-t g-r-a-n-t force-pushed the workspace branch 2 times, most recently from fe107eb to 0be0a65 Compare January 8, 2026 02:11
@sbillig sbillig mentioned this pull request Jan 8, 2026
Open
25 tasks
@g-r-a-n-t g-r-a-n-t force-pushed the workspace branch 5 times, most recently from b808912 to a4d35d7 Compare January 19, 2026 21:07
@g-r-a-n-t g-r-a-n-t force-pushed the workspace branch 5 times, most recently from 2b7263e to 109cf36 Compare January 24, 2026 16:25
@g-r-a-n-t g-r-a-n-t changed the title workspaces Basic workspace support Jan 24, 2026
@g-r-a-n-t g-r-a-n-t mentioned this pull request Jan 24, 2026
Closed
@cburgdorf
Copy link
Collaborator

cburgdorf commented Jan 28, 2026

@g-r-a-n-t Just a quick tip, I see that you assigned us but better to pick us from the "Reviewers" box as that will trigger the proper ask for review process that you probably meant to use.

@cburgdorf cburgdorf requested a review from Copilot January 28, 2026 10:03
cburgdorf
cburgdorf approved these changes Jan 28, 2026
View reviewed changes
Copy link
Collaborator

@cburgdorf cburgdorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very solid to me. A minor complain (which I haven't actually verified) would be that the approach for updating the TOML file most likely evaporates all existing comments of that TOML file but I don't think that has to be addressed as part of this PR.

Great work!

Copilot AI reviewed Jan 28, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@g-r-a-n-t
Copy link
Collaborator Author

g-r-a-n-t commented Jan 28, 2026

A minor complain (which I haven't actually verified) would be that the approach for updating the TOML file most likely evaporates all existing comments of that TOML file but I don't think that has to be addressed as part of this PR.

Yeah, that's a problem. I've been having second thoughts about that feature and might just remove it in a small followup PR.

@g-r-a-n-t g-r-a-n-t merged commit f4e8f1e into argotorg:master Jan 28, 2026
11 checks passed
@g-r-a-n-t g-r-a-n-t mentioned this pull request Feb 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@cburgdorf cburgdorf cburgdorf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@g-r-a-n-t @cburgdorf @sbillig @micahscopes