Add std::prelude, auto-inject for all user ingots#1279
Merged
sbillig merged 3 commits intoargotorg:masterfrom Feb 25, 2026
Merged
Add std::prelude, auto-inject for all user ingots#1279sbillig merged 3 commits intoargotorg:masterfrom
sbillig merged 3 commits intoargotorg:masterfrom
Conversation
Collaborator
Author
|
@sbillig @cburgdorf @g-r-a-n-t I have no strong opinions about this, please chime in or even push a change if you like |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00edc9da5c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Collaborator
|
I don't have strong opinions. Would just prefer to have it merged quickly. |
Collaborator
|
@g-r-a-n-t I'm adding Ctx, StorageMap, Create, Log, then will merge. <30 minutes. |
Create std::prelude that re-exports core::prelude plus common EVM/ABI
items that nearly every contract needs:
- core::abi::{Abi, AbiEncoder, AbiSize, Encode} (71% of contracts)
- std::abi::Sol (71%)
- std::evm::{Evm, Address, Call, assert} (34-97%)
User ingots now get `use std::prelude::*` injected instead of
`use core::prelude::*`. The std ingot itself still gets core::prelude
(no self-import). This eliminates 2-4 boilerplate import lines from
the top of virtually every contract file.
Closes argotorg#1228
Instead of choosing between core::prelude or std::prelude, always inject core::prelude as baseline and additionally inject std::prelude for non-std ingots. If the std dependency lacks a prelude module (e.g. a user-defined package aliased as "std"), the synthetic import fails silently and core::prelude still provides Option, Result, etc. This avoids the edge case where IngotKind::Std is assigned to user-defined packages named "std" that don't actually have a prelude, which would have silently dropped all implicit imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::preludemodule that re-exportscore::prelude::*plus common EVM and ABI itemscore::prelude::*tostd::prelude::*for user ingotsWhat's in std::prelude
assertstd::evm::effects::assertAbi,AbiEncoder,AbiSize,Encodecore::abiSolstd::abi::SolEvmstd::evm::EvmCallstd::evm::CallAddressstd::evm::AddressPlus everything already in
core::prelude(Clone, Copy, Default, Option, Result, etc.).What's NOT in the prelude (still requires explicit import)
Ctx,StorageMap,Create,Log, low-levelops::*,mem,TStorPtr— these are common but not universal enough to warrant implicit availability.Implementation
ingots/std/src/prelude.fe: new file, re-exports core::prelude + tier 1/2 itemscrates/hir/src/core/lower/mod.rs: user ingots getstd::prelude::*, std ingot still getscore::prelude::*(no self-import)std::preludepath, one CLI snapshot has shifted line numbersTest plan
cargo buildcleancargo clippy --all-targetscleancargo test— 546 tests pass, 0 failuresCloses #1228