Workaround fix for issue with inline namespace thrust#3566
Merged
christophe-murphy merged 3 commits intoarrayfire:masterfrom Nov 5, 2024
Merged
Workaround fix for issue with inline namespace thrust#3566christophe-murphy merged 3 commits intoarrayfire:masterfrom
christophe-murphy merged 3 commits intoarrayfire:masterfrom
Conversation
Contributor
|
Hi Edwin, thanks for finding this! I was trying to compile with Windows and wondering what was going on! I just have a couple of comments, I think things might have got messed up by clang format. Thanks |
|
Would be good to land this, I got stuck on it for a couple hours. |
Hi Edwin, there seems to be an issue caused by the clang format apply. I propose these changes.
Contributor
|
I made some changes. Compiling works on my Windows runner, see here: https://github.com/christophe-murphy/arrayfire/actions/runs/11387289958/job/31681529494 If you are happy with it, then I'll merge it. |
Contributor
Author
|
Looks good to me! Go ahead and merge it |
christophe-murphy
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix for inline namespace with thrust compiling with MSVC
Description
ThrustArrayFirePolicy.hppFixes: [Build] MSVC Compiler Bug affecting thrust library in CUDA Backend #3565
Changes to Users
Checklist