Simplify comparison strategy isLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy#3694
Merged
joel-costigliola merged 2 commits intoassertj:3.xfrom Dec 8, 2024
cookieMr:simplity_is_less_than_or_eq_to
Merged
Simplify comparison strategy isLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy#3694joel-costigliola merged 2 commits intoassertj:3.xfrom cookieMr:simplity_is_less_than_or_eq_to
isLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy#3694joel-costigliola merged 2 commits intoassertj:3.xfrom
cookieMr:simplity_is_less_than_or_eq_to
Conversation
cookieMr
commented
Dec 8, 2024
| @Override | ||
| public boolean isLessThan(Object actual, Object other) { | ||
| return !areEqual(actual, other) && !isGreaterThan(actual, other); | ||
| return !isGreaterThanOrEqualTo(actual, other); |
Contributor
Author
There was a problem hiding this comment.
simple De Morgan's law -> https://en.wikipedia.org/wiki/De_Morgan%27s_laws
cookieMr
commented
Dec 8, 2024
| @Override | ||
| public boolean isLessThanOrEqualTo(Object actual, Object other) { | ||
| return areEqual(actual, other) || isLessThan(actual, other); | ||
| return !isGreaterThan(actual, other); |
Contributor
Author
There was a problem hiding this comment.
no need to call twice the areEqual (2nd call was negated)
Member
|
Good catch, thanks @cookieMr. |
isLessThan and isLessThanOrEqualTo
isLessThan and isLessThanOrEqualToisLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.