This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Restructure tracers#97
Merged
liyanhui1228 merged 2 commits intocensus-instrumentation:masterfrom Dec 12, 2017
Merged
Conversation
duggelz
suggested changes
Dec 12, 2017
| .. code:: python | ||
|
|
||
| from opencensus.trace import request_tracer | ||
| from opencensus.trace import tracer as tracer_module |
There was a problem hiding this comment.
Yes, this looks good. I always struggle with the "package/module/class/variable" naming, since I have up to four things but only two ways (Uppercase/lowercase) to name them.
README.rst
Outdated
| .. code:: python | ||
|
|
||
| from opencensus.trace.tracer import webapp2_tracer | ||
| from opencensus.trace.tracers import webapp2_tracer |
There was a problem hiding this comment.
I can't find the webapp2 files, are you going to add them to the 'ext' directory in this PR or a later one?
Contributor
Author
There was a problem hiding this comment.
Deleted it for now, probably add it in later PR.
duggelz
approved these changes
Dec 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.