tools: patch jinja2 for Python 3.10 compat#3
Closed
qwell wants to merge 1 commit intocitizenfx:cfx/node-12from
qwell:cfx/node-12
Closed
tools: patch jinja2 for Python 3.10 compat#3qwell wants to merge 1 commit intocitizenfx:cfx/node-12from qwell:cfx/node-12
qwell wants to merge 1 commit intocitizenfx:cfx/node-12from
qwell:cfx/node-12
Conversation
PR-URL: nodejs#40296 Fixes: nodejs#40294 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
why 12 |
Author
cfx/node-12 is the default branch according to github. Is that not the case? When doing a submodule init, that's the branch that gets checked out. |
Nope, the commit that's referenced is on https://github.com/citizenfx/node/tree/cfx/node-16 only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: nodejs#40296
Fixes: nodejs#40294
Reviewed-By: Jiawen Geng technicalcute@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Christian Clauss cclauss@me.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes