Merged
Conversation
it does not compile now
boost::shared_future has a richer api, notably it has the `is_ready()` method required by the `ready()` wrapper
281cb0c to
d7bec0a
Compare
Member
|
All tests on Travis failed. @cinghiale ignore the tests for clang right now, we already now that they don't work. However, it looks like you have added a dependency to Boost.System to cpp-netlib, and their is a linking error for the tests and examples. |
Author
|
Added the missing libraries. Waiting for the CI... |
Author
|
Still some failures... I'll try to fix soon |
Author
|
@glynos I'm a bit puzzled by the failings. Looking at the output it looks like we found an ICE in one of the tests: On my ubuntu box (16.10) I have access to gcc 4.8.5 and it compiles fine. any suggestion is very appreciated |
Member
|
I think we don't need to block this on the CI results. We should be able to fix this after the fact. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #684 against the master branch