Add a pyproject.toml file#269
Merged
aaronliu0130 merged 2 commits intocpplint:developfrom May 13, 2024
Merged
Conversation
Contributor
Author
|
I don't fully know how to read the output, but it looks like the failing test is because the index of something in a list of errors has changed from 5 to 4: It may be related to this changeset insofar as the output of some build step could like quite different now because pip outputs different lines (and runs some different setup) solely on the basis of pyproject.toml existing. That's just a guess, though; I'm afraid I don't really know what this test is intended for. |
Member
Member
|
Merged. @vyasr Could you sync with our latest commit? |
Contributor
Author
|
Merged the latest develop, thanks! |
aaronliu0130
approved these changes
May 13, 2024
rapids-bot bot
pushed a commit
to rapidsai/ucxx
that referenced
this pull request
Dec 2, 2024
This PR updates our pre-commit to use the latest version of cpplint. This brings in [my fix](cpplint/cpplint#269) that ensures that the pre-commit hook actually works in all environments. Without that fix, depending on the version of Python and setuptools in the base environment the cpplint installation may fail. Authors: - Vyas Ramasubramani (https://github.com/vyasr) - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By explicitly specifying the legacy setuptools build backend via pyproject.toml, we ensure that the current directory is visible to the setup.py invocation. Without this, in some environments I observe that pip installing the sdist or a clone of the repo fails because the current directory is not on the PYTHONPATH (for instance, using cpplint as a pre-commit hook fails for me on some Python/pip versions). Note that this is because the setup.py in this repo imports the cpplint module from the current directory, and for this reason it is necessary to specify that the build backend is
setuptools.build_meta:__legacy__, not justsetuptools.build_meta.