fix(readability/casting): noexcept *functions#377
Open
aaronliu0130 wants to merge 2 commits intodevelopfrom
Open
fix(readability/casting): noexcept *functions#377aaronliu0130 wants to merge 2 commits intodevelopfrom
aaronliu0130 wants to merge 2 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a false positive in the C-style cast checker where function pointers with noexcept specifiers were incorrectly flagged as deprecated casts. The fix adds noexcept to the list of keywords that indicate a function declaration rather than a cast.
- Adds
noexceptto the regex pattern that identifies function declarations - Updates the comment to clarify that function pointers are handled
- Adds a test case for function pointers with noexcept specifiers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpplint.py | Modified regex pattern to include noexcept as a keyword indicating function declarations and updated comment for clarity |
| cpplint_unittest.py | Added test case for function pointer with noexcept specifier to verify the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354
this shall be squashed