Preserve source map key order for torrent files#6
Merged
dampcake merged 2 commits intodampcake:masterfrom Jul 15, 2019
TheLQ:master
Merged
Preserve source map key order for torrent files#6dampcake merged 2 commits intodampcake:masterfrom TheLQ:master
dampcake merged 2 commits intodampcake:masterfrom
TheLQ:master
Conversation
dampcake
requested changes
Jul 8, 2019
Owner
dampcake
left a comment
There was a problem hiding this comment.
I think adding some tests around the ordering expectations makes sense too.
| @SuppressWarnings("unchecked") | ||
| public void testWriteDictionary() throws Exception { | ||
| instance.writeDictionary(new HashMap<Object, Object>() {{ | ||
| instance.writeDictionary(new TreeMap<Object, Object>() {{ |
Owner
There was a problem hiding this comment.
I think it makes more sense to use a LinkedHashMap and modify the expectation.
Will probably make the tests a little easier to read too!
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
============================================
- Coverage 99.47% 99.46% -0.01%
+ Complexity 86 85 -1
============================================
Files 7 7
Lines 191 188 -3
Branches 28 27 -1
============================================
- Hits 190 187 -3
Partials 1 1
Continue to review full report at Codecov.
|
Contributor
Author
|
Added those tests. Unless you think otherwise, the TreeMap ordering test was just removed instead of copied to a new test. |
dampcake
approved these changes
Jul 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple change to keep the source order of keys in maps. Useful for