Merged
Conversation
This prevent the script to generate a new certificate every time the module is updated. `certs.js` manages the certificates: creation and deletion, and provides them to index.js. An uninstall script is added, it deletes the folder at uninstall time. makes problems, generate the certificates at first run. If the index.js won't find the certificates, certs.js will generate them. Some edits in README accordingly to changes. Add also a link on README to CONTRIBUTING. Upgrade to v4.1.0 in package.json. Upgrade of dependencies.
Fixes a brutal crash in case of address 443 or 80 already in use on the machine and if the script is not runned under sudo on linux. The script exit, but writing an error message and a tip on how to resolve. Update README consequently. Upgrade minimum node version to 8.
Add pkg to package all this code into an executable that doesn't require a node.js installation. This allow to easly distribute this tool.
Repository owner
deleted a comment from
coveralls
Apr 23, 2019
Repository owner
deleted a comment from
coveralls
Apr 23, 2019
4 tasks
daquinoaldo
added a commit
that referenced
this pull request
Aug 18, 2019
- Update to mkcert v1.4.0: macOS Catalina compatibility and more. https://github.com/FiloSottile/mkcert/releases/tag/v1.4.0 - Add `REINSTALL=true serve` env variable to force reinstall certs. - Check for updates if running as compiled executable (downloaded from GitHub releases). - Update dependencies. - Add troubleshooting for #13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Related Issue
This closes #8 (AppData), closes #10 (first run), and closes #11 (EACCES). Should solve #9.
Types of changes
Checklist