Add agent detection for Cline, Codex, Antigravity and OpenCode#4496
Merged
simonfaltum merged 4 commits intomainfrom Feb 12, 2026
Merged
Add agent detection for Cline, Codex, Antigravity and OpenCode#4496simonfaltum merged 4 commits intomainfrom
simonfaltum merged 4 commits intomainfrom
Conversation
Refactor agent detection to use a table-driven approach so adding new agents requires only a constant and a table entry. New agents: Cline (CLINE_ACTIVE), Codex (CODEX_CI), OpenCode (OPENCODE). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
simonfaltum
commented
Feb 12, 2026
| ) | ||
| // knownAgents maps environment variables to product names. | ||
| // Adding a new agent only requires a new entry here and a new constant above. | ||
| var knownAgents = []struct { |
Member
Author
There was a problem hiding this comment.
wanted to have copilot as well but it doesn't look like it sets any ENV vars
simonfaltum
commented
Feb 12, 2026
|
|
||
| ctx = withAgentInUserAgent(ctx) | ||
| assert.Contains(t, useragent.FromContext(ctx), "agent/cursor") | ||
| func TestAgentInUserAgent(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
thought it was best to not repeat the same test 6 times..
Collaborator
|
Commit: a77e8bf
34 interesting tests: 16 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED, 1 FAIL
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Feb 12, 2026
libs/agent/agent.go
Outdated
Comment on lines
33
to
38
Contributor
There was a problem hiding this comment.
[no action required] The key should ideally be an empty struct.
type productKeyType struct{}
var productKey productKeyTypeThis is the idiomatic way to represent context key: it has zero size and no meaning.
| // Mock is a helper for tests to mock the detection result. | ||
| func Mock(ctx context.Context, product string) context.Context { | ||
| return context.WithValue(ctx, productKey, product) | ||
| } |
Contributor
There was a problem hiding this comment.
[no action required] Testing utilities are typically exposed is a separate package than the one they test. For example, http testing utilities are in httptest (same for io).
I understand this cannot be done here because the key is private, though, this is potentially a consequence of the package having a blurry responsibility boundary with the package that manages user-agents. For example, we could focus this package purely on agent extraction and let the package responsible for managing the useragent decide how to leverage it. This would allow us to centralize the useragent management in one place, while still having all the agent resolution logic nicely encapsulated. In that context, this function would not need to exist I believe.
renaudhartert-db
approved these changes
Feb 12, 2026
pietern
reviewed
Feb 12, 2026
Contributor
pietern
left a comment
There was a problem hiding this comment.
@simonfaltum Can you include references to where you found these env vars?
Just so we can trace them to the source if we need to later.
Member
Author
|
@pietern Added antigravity as well, and updated the sources. A few of them are closed source and it's basically "I tried this locally" :/ |
…text key - Add ANTIGRAVITY_AGENT env var for Google Antigravity detection - Add source reference comments for all agent env vars - Use zero-size struct for context key (idiomatic Go pattern) - Clear all agent env vars in acceptance test config
Contributor
|
Thanks, the refs are great. When I looked at this last month Codex didn't export this yet. Via your ref I found this PR: openai/codex#9366 |
Contributor
|
Can you update the PR title as well (or just say "expand"). |
Member
Author
|
It would be great to have Windsurf but I think that will have to come another time as it is closed source |
pietern
approved these changes
Feb 12, 2026
Collaborator
|
Commit: 884d6b7
33 interesting tests: 17 flaky, 8 KNOWN, 5 SKIP, 3 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLINE_ACTIVE), Codex (CODEX_CI), OpenCode (OPENCODE) and AntigravityknownAgentsslice, so adding a new agent only requires a new constant and one table entryTest plan
go test ./libs/agent/ -v— all detection tests passgo test ./cmd/root/ -run TestAgent -v— all user agent tests pass🤖 Generated with Claude Code