deepsentinel · sunnyanthony · Jun 17, 2021 · Jun 17, 2021 · Jun 17, 2021 · Jun 17, 2021
diff --git a/.coveragerc b/.coveragerc
@@ -0,0 +1,5 @@
+[report]
+exclude_lines = 
+    pragma: no cover
+    if TYPE_CHECKING:
+    if sys.version_info
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,64 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - "**"
+
+jobs:
+  build:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+        python-version: [3.6, 3.7, 3.8, 3.9, pypy3]
+        include:
+          - os: ubuntu-latest
+            venvcmd: . env/bin/activate
+          - os: macos-latest
+            venvcmd: . env/bin/activate
+          - os: windows-latest
+            venvcmd: env\Scripts\Activate.ps1
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/cache@v2
+        id: cache
+        with:
+          path: env
+          key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('**/Makefile') }}-${{ hashFiles('**/requirements-dev.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ hashFiles('**/Makefile') }}
+      - name: Install dependencies
+        if: steps.cache.outputs.cache-hit != 'true'
+        run: |
+          python -m venv env
+          ${{ matrix.venvcmd }}
+          pip install --upgrade -r requirements-dev.txt pytest-github-actions-annotate-failures
+      - name: Run flake8
+        if: ${{ runner.os == 'Linux' && matrix.python-version != 'pypy3' }}
+        run: |
+          ${{ matrix.venvcmd }}
+          make flake8
+      - name: Run mypy
+        if: ${{ runner.os == 'Linux' && matrix.python-version != 'pypy3' }}
+        run: |
+          ${{ matrix.venvcmd }}
+          make mypy
+      - name: Run black_check
+        if: ${{ runner.os == 'Linux' && matrix.python-version != 'pypy3' }}
+        run: |
+          ${{ matrix.venvcmd }}
+          make black_check
+      - name: Run tests
+        run: |
+          ${{ matrix.venvcmd }}
+          make test_coverage
+      - name: Report coverage to Codecov
+        uses: codecov/codecov-action@v1
diff --git a/.gitignore b/.gitignore
@@ -11,3 +11,6 @@ Thumbs.db
 .cache
 .mypy_cache/
 docs/_build/
+.vscode
+/dist/
+/zeroconf.egg-info/
diff --git a/.travis.yml b/.travis.yml
diff --git a/Makefile b/Makefile
@@ -1,49 +1,53 @@
+# version: 1.1
+
 .PHONY: all virtualenv
 MAX_LINE_LENGTH=110
 PYTHON_IMPLEMENTATION:=$(shell python -c "import sys;import platform;sys.stdout.write(platform.python_implementation())")
 PYTHON_VERSION:=$(shell python -c "import sys;sys.stdout.write('%d.%d' % sys.version_info[:2])")
-TEST_ARGS=
 
 LINT_TARGETS:=flake8
 
 ifneq ($(findstring PyPy,$(PYTHON_IMPLEMENTATION)),PyPy)
-	LINT_TARGETS:=$(LINT_TARGETS) mypy
-endif
-ifeq ($(or $(findstring 3.5,$(PYTHON_VERSION)),$(findstring PyPy,$(PYTHON_IMPLEMENTATION))),)
-	LINT_TARGETS:=$(LINT_TARGETS) black_check
+	LINT_TARGETS:=$(LINT_TARGETS) mypy black_check pylint
 endif
 
 
 virtualenv: ./env/requirements.built
 
 env:
-	virtualenv env
+	python -m venv env
 
 ./env/requirements.built: env requirements-dev.txt
 	./env/bin/pip install -r requirements-dev.txt
 	cp requirements-dev.txt ./env/requirements.built
 
 .PHONY: ci
-ci: test_coverage lint
+ci: lint test_coverage
 
 .PHONY: lint
 lint: $(LINT_TARGETS)
 
 flake8:
 	flake8 --max-line-length=$(MAX_LINE_LENGTH) setup.py examples zeroconf
 
+pylint:
+	pylint zeroconf
+
 .PHONY: black_check
 black_check:
 	black --check setup.py examples zeroconf
 
 mypy:
-	mypy examples/*.py zeroconf/*.py
+# --no-warn-redundant-casts --no-warn-unused-ignores is needed since we support multiple python versions
+# We should be able to drop this once python 3.6 goes away
+	mypy --no-warn-redundant-casts --no-warn-unused-ignores examples/*.py zeroconf
 
 test:
-	nosetests -v $(TEST_ARGS)
+	pytest --durations=20 --timeout=60 -v tests
 
 test_coverage:
-	nosetests -v --with-coverage --cover-package=zeroconf $(TEST_ARGS)
+	pytest --durations=20 --timeout=60 -v --cov=zeroconf --cov-branch --cov-report xml --cov-report html --cov-report term-missing tests
 
 autopep8:
 	autopep8 --max-line-length=$(MAX_LINE_LENGTH) -i setup.py examples zeroconf
+