Draft: comment out some nuget packages#120
Open
MakiWolf wants to merge 10 commits intodotdevelop:mainfrom
Open
Draft: comment out some nuget packages#120MakiWolf wants to merge 10 commits intodotdevelop:mainfrom
MakiWolf wants to merge 10 commits intodotdevelop:mainfrom
Conversation
Member
|
@MakiWolf thanks for your PR. Can you please:
|
Author
|
@knocte Thank you for feedback.
I will do this in future.
I have turned on github actions and here is the output: https://github.com/MakiWolf/dotdevelop/actions/runs/5647216462 |
Member
You can still change it in this PR and if whoever merges it squashes commits, then the git-blame-noise is averted. |
Author
@knocte I have made a commit now and changed this. But please note that this PR is experimental. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nuget package Microsoft.VisualStudio.CodingConventions
Since #112 where a package is not avilable any more, I have commented that code out that it is building now without it. Maybe it is useful? Hope I commented out everything where it is downloaded. There needs to be much to comment out, but do we have an alternative? I have not tested if there are crashes and what features are missing.