Swallow message errors and continue.#587
Merged
peterbarker merged 2 commits intomasterfrom Mar 1, 2016
Merged
Conversation
Contributor
|
@tcr3dr Tests failed - no idea how to unblock appveyor. This looks sane. Any way we could print out the listener function name if it exists as well - would make debugging just a little easier. |
Contributor
|
Also this is labelled WIP, so won't do anything until you say :-) |
Contributor
|
👍 LGTM |
Contributor
Author
|
@peterbarker This is no longer a WIP, since it's about done. We do not need it in production, but it can still land if anyone is interested. |
peterbarker
added a commit
that referenced
this pull request
Mar 1, 2016
Catch and display message and attribute errors, then continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because a failed "*" handler can kill all subsequent message handlers, it becomes very hard to track down where an error is being found.
This patch handles errors consistently with how they are handled at a higher level (in
mavlink_thread_in). A more robust error handling mechanism (with configurable logging) is desired, but this patch is more essential for now.