Open
Conversation
profpandaa
reviewed
Oct 23, 2025
Contributor
profpandaa
left a comment
There was a problem hiding this comment.
This PR introduces quite a few (undocumented) changes at once. I don't know the codebase (nor the language) enough, to properly review it though.
What I can say is, the pool selector refactoring looks easier to read in the original one (while using a var less).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the manual timezone configuration with dynamic timezone detection using the
ezTimelibrary. The device now determines its timezone based on the IP address using the public APIip-api.com.Changes introduced
ezTimelibrary for timezone and NTP supportsetTimezone()function withsetTimezoneByIP(), which:tz.setLocation()using the received timezone stringwaitForSync())getLocalTime()withezTime::now()andlocaltime()for building thestruct tmupdateTimeDisplayData()to reflect the new timezone-aware implementationstrftime()Benefits
Notes
ezTimelibrary must be installed via the Arduino Library Manager