Skip to content

Comments

108 plugin doesnt properly support tests with trailing spaces#109

Merged
eirikb merged 2 commits intomainfrom
108-plugin-doesnt-properly-support-tests-with-trailing-spaces
Jun 8, 2023
Merged

108 plugin doesnt properly support tests with trailing spaces#109
eirikb merged 2 commits intomainfrom
108-plugin-doesnt-properly-support-tests-with-trailing-spaces

Conversation

@eirikb
Copy link
Owner

@eirikb eirikb commented Jun 8, 2023

This PR should enable matching of tests with trailing spaces. And when there are multiple spaces in the middle.

I noticed there seems to be some kind of handling for this already by @BlackHole1 but that part won't run if the test name is a stringValue of expression. Didn't know if some of the logic could be shared, but this seems to work fine.

@eirikb eirikb linked an issue Jun 8, 2023 that may be closed by this pull request
@eirikb eirikb merged commit 40069fc into main Jun 8, 2023
@eirikb eirikb deleted the 108-plugin-doesnt-properly-support-tests-with-trailing-spaces branch June 8, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin doesn't properly support tests with trailing spaces

1 participant