instrumentation/kafka: fix handling consumer iteration if transaction not sampled#2075
Merged
xrmx merged 1 commit intoelastic:mainfrom Jul 9, 2024
Merged
Conversation
… not sampled Handle the case where if the transaction is not sampled capture_span will return None instead of span. While at it fix handling of checking for KAFKA_HOST in tests. Fix elastic#2073
1456d47 to
0b25489
Compare
basepi
approved these changes
Jul 3, 2024
xrmx
added a commit
to xrmx/apm-agent-python
that referenced
this pull request
Aug 19, 2024
… not sampled (elastic#2075) Handle the case where if the transaction is not sampled capture_span will return None instead of span. While at it fix handling of checking for KAFKA_HOST in tests. Fix elastic#2073
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Handle the case where if the transaction is not sampled capture_span will return None instead of a span.
While at it fix handling of checking for KAFKA_HOST in tests.
Related issues
Closes #2073