Use unittest.mock instead of the mock backport package#2370
Merged
xrmx merged 2 commits intoelastic:mainfrom Jul 30, 2025
Merged
Use unittest.mock instead of the mock backport package#2370xrmx merged 2 commits intoelastic:mainfrom
xrmx merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
393d744 to
95ce61f
Compare
Use the standard library module instead of the backported package. Should fix mocks failures with Python 3.13.
95ce61f to
01b3dfa
Compare
trentm
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
After spending some fun time debugging a client test failure and wondering if we had any bug in our queue handling it looks like the cause was some silent mock failures where the expected method was not patched. Switching to unittest.mock seems to work fine.
While at it fix warnings about missing azure storage pytest marker.
Related issues
Closes #2364