Add postgresql+asyncpg scheme prefix (closes #395)#396
Add postgresql+asyncpg scheme prefix (closes #395)#396aminalaee merged 22 commits intoencode:masterfrom
Conversation
|
Ok, I bring this up only because SQLAlchemy supports the format More background: I'm writing a FastAPI project and using fastapi-users which requires Databases. So I'm stuck having to supply a DB URL to both libraries. Ideally these should be able to be the same, and since one's built on the other, they shouldn't act differently anyway. If it's not ok to have multiple mappings for a backend (i.e. specifying all valid schemes), I propose the following strategy:
|
|
I agree that making it specific |
|
ok sounds good, will write the test asap
… On Sep 23, 2021, at 15:45, Amin Alaee ***@***.***> wrote:
I agree that making it specific dialect+driver looks better. But as you said if we could handle both cases it would be great for backwards-compatibility too.
This just needs the missing test coverage, and we can merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Co-authored-by: Amin Alaee <mohammadamin.alaee@gmail.com>
aminalaee
left a comment
There was a problem hiding this comment.
Thanks for this. I fixed the rest of tests.
No description provided.