Skip to content

style: PEP 8 fixes in openapi/utils.py#14754

Closed
ImJuike wants to merge 1 commit intofastapi:masterfrom
ImJuike:patch-1
Closed

style: PEP 8 fixes in openapi/utils.py#14754
ImJuike wants to merge 1 commit intofastapi:masterfrom
ImJuike:patch-1

Conversation

@ImJuike
Copy link

@ImJuike ImJuike commented Jan 22, 2026

Changes:

  • Added missing trailing commas in validation_error_response_definition
  • Fixed string concatenation in warning message

Type: Code style cleanup (PEP 8)

Added missing trailing commas in 'validation_error_response_definition'
Fixed string concatenation in warning message to use implicit concatenation
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing ImJuike:patch-1 (060ca04) with master (2eb978b)1

Summary

✅ 20 untouched benchmarks

Footnotes

  1. No successful run was found on master (e0abd21) during the generation of this report, so 2eb978b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ImJuike
Copy link
Author

ImJuike commented Jan 22, 2026

Hi! The label check is failing. Could a maintainer please add the "refactor" label?

This PR only contains style fixes (trailing commas and string concatenation).

@YuriiMotov
Copy link
Member

We use ruff to check\fix code formatting.
If code passes ruff checks and it's readable, I think there is no need to update it.
And, if we decide to follow some additional optional rules, we should enable them in ruff's config.

In this case I think we don't need to change anything. I suggest we close this PR.

@ImJuike, thanks for your interest and efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants