🐛 Fix handling sequences with nested Annotated types#14874
Open
YuriiMotov wants to merge 4 commits intomasterfrom
Open
🐛 Fix handling sequences with nested Annotated types#14874YuriiMotov wants to merge 4 commits intomasterfrom
YuriiMotov wants to merge 4 commits intomasterfrom
Conversation
fd31d1d to
1aa1a62
Compare
1aa1a62 to
cda2003
Compare
field_annotation_is_scalar_sequence
clefeu
reviewed
Feb 11, 2026
…ted-types-in-field_annotation_is_scalar_sequence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on
masterbranch the following code example fails on startup:(the error traceback is a bit misleading - the issue is actually not in
is_scalar_field, but infield_annotation_is_scalar_sequencewhich is a part of the sameassert)This is because
field_annotation_is_scalar_sequencedoesn't unwrapAnnotated.We also need to unwrap
Annotatedinfield_annotation_is_sequenceto make_get_multidict_valuecorrectly recognize this parameter as sequence and extract the value usingget_list.See: #14852