🐛 Fix implicit path params with converters#14883
Open
Dawaman43 wants to merge 4 commits intofastapi:masterfrom
Open
🐛 Fix implicit path params with converters#14883Dawaman43 wants to merge 4 commits intofastapi:masterfrom
Dawaman43 wants to merge 4 commits intofastapi:masterfrom
Conversation
Merging this PR will not alter performance
Comparing 
|
Member
|
@Dawaman43, please don't merge |
Author
|
ok sorry
…On Tue, 10 Feb 2026 at 15:01, Motov Yurii ***@***.***> wrote:
*YuriiMotov* left a comment (fastapi/fastapi#14883)
<#14883 (comment)>
@Dawaman43 <https://github.com/Dawaman43>, please don't merge master
branch so often - it creates noise in the notifications
—
Reply to this email directly, view it on GitHub
<#14883 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCKYMSHQ46W44ZLPHOM4F3L4LHCCJAVCNFSM6AAAAACUS4GUOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNZXGE3TGNBQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routes that use path converters (e.g.
{param:path}) are not detected as path parameters when the parameter is declared implicitly(without
Path()), becauseget_path_param_names()returns the raw token including the converter suffix.This causes the parameter to be treated as a query parameter and the request to fail.
Changes Made
get_path_param_names()so{param:path}is recognized asparam.param: strpath parameter works with thepathconverter.Why it matters
This aligns implicit parameters with explicit
Path()behavior and restores correct routing for path-converter syntax.Testing
tests/test_starlette_urlconvertors.py.