add References object to PlotArea, other cleanup, better garbage collection#467
Merged
kushalkolar merged 8 commits intomainfrom Apr 2, 2024
Merged
add References object to PlotArea, other cleanup, better garbage collection#467kushalkolar merged 8 commits intomainfrom
References object to PlotArea, other cleanup, better garbage collection#467kushalkolar merged 8 commits intomainfrom
Conversation
Member
Author
|
Using the linear region selectors notebook to try adn understand what holds onto references since selectors have lots of events.
|
Member
Author
|
A base
|
References object to PlotArea, other cleanupReferences object to PlotArea, other cleanup, better garbage collection
clewis7
reviewed
Apr 2, 2024
Member
clewis7
left a comment
There was a problem hiding this comment.
LGTM, REFERENCES class very elegant
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #463
Adds new
Referencesobject for which there is a single global instance for one instance of Python.This helps segregate
Graphic,Selector,Legendand any other objects we might want to have in the future.start using prefix
_fpl_*for any attributes/methods that are for fpl internal use only, to distinguish them from actual private attributesMoved selector
_fpl_cleanuptoGraphic._fpl_cleanupNeed to add tests for:
PlotArea