Merged
Conversation
Member
Author
|
when reviewing don't be scared by the size of the diff, it's mostly stuff being moved around, and the changes to the examples are mostly renaming stuff from plot -> figure, gridplot -> figure 😄 |
clewis7
previously approved these changes
Apr 9, 2024
Member
clewis7
left a comment
There was a problem hiding this comment.
LGTM, mostly just a big refactor but I think this cleans up a lot of the soup and better organizes the repo
3 tasks
* fefactor imwidget, restrict to tzxy, txy, xy, added RGB(A) support (#459) * add new iw test screenshots * update api docs --------- Co-authored-by: Amol Pasarkar <amolpasarkar@gmail.com>
Member
Author
|
Idea: if edit: No, keep things consistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #457
This PR breaks everything 😄
Gridplotrenamed toFigurePlotis removed in favor of just doingFigure()since the defaultshape=(1, 1), i.e. "gridplot" with a single subplotFramemerged intoFigureRecordMixin->FigureRecorderrecordis now an instance ofFigure, use composition instead of inheritance, I haven't tested that this works yet, right now it's still a very experimental feature_framemodule renamed tooutput, some reorganization of what is public/private within that module to make it more logicalImageWidgetStill need to do this for
ImageWidget, waiting for #459 , rest of it is good to go and tests are passing on my end 🥳