Skip to content

use cmap library for colormaps (#390)#574

Merged
kushalkolar merged 3 commits intomainfrom
cmap-intermediate
Jul 31, 2024
Merged

use cmap library for colormaps (#390)#574
kushalkolar merged 3 commits intomainfrom
cmap-intermediate

Conversation

@kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Jul 31, 2024

  • example with cmap

  • add to deps

  • fix shape

  • use full map

  • remove break

  • undo changes to screenshots

  • fix parse

  • remove diffs

  • remove x.py

  • minimize diff

  • add docstring

  • remove colormaps

@tlambert03 @kushalkolar
use cmap library for colormaps (#390)
1c92d97 
* example with cmap

* add to deps

* fix shape

* use full map

* remove break

* undo changes to screenshots

* fix parse

* remove diffs

* remove x.py

* minimize diff

* add docstring

* remove colormaps

---------

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>
@kushalkolar kushalkolar requested a review from clewis7 as a code owner July 31, 2024 05:27
@kushalkolar
Copy link
Member Author

kushalkolar commented Jul 31, 2024 •
edited
Loading

@clewis7 can you see if you are able to approve this? IDK why the docs build is failing, but the actual readthedocs PR build seems fine, maybe realted to pygfx/pygfx#825 . Should be fine in a few days.

@kushalkolar kushalkolar mentioned this pull request Jul 31, 2024
Merged
17 tasks
@kushalkolar kushalkolar merged commit 85337ba into main Jul 31, 2024
@kushalkolar kushalkolar deleted the cmap-intermediate branch July 31, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clewis7 clewis7 clewis7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kushalkolar @clewis7 @tlambert03