Skip to content

Comments

Adding top gui to fpl#999

Open
clewis7 wants to merge 6 commits intomainfrom
top-gui
Open

Adding top gui to fpl#999
clewis7 wants to merge 6 commits intomainfrom
top-gui

Conversation

@clewis7
Copy link
Member

@clewis7 clewis7 commented Feb 20, 2026

image

I thought this would follow the patterns of the other guis (just change the y pos of where pygfx renders to), but the render space does not actually move down unless I manually set the rect

Maybe that is not something that needs to be done for bottom and right but does for a left or top gui

Have enough for the thing I need to do for clepio and can circle back to this

@kushalkolar thoughts welcome since you did the frame/rect manager stuff

@clewis7 clewis7 requested a review from kushalkolar as a code owner February 20, 2026 02:05
@clewis7 clewis7 marked this pull request as draft February 20, 2026 02:05
@kushalkolar
Copy link
Member

I'm brain fried I'll review tomorrow or this weekend, but if right and bottom imgui windows still work then it's probably fine, let's worry about left guis when there's a compelling use case?

@clewis7
Copy link
Member Author

clewis7 commented Feb 20, 2026

Proper logic for setting the pyfgx render space and allowing space for guis is in _imgui_figure.py and ui/_base.py

The issue now is getting the rect manager and frame to obey the change in the y-coord

image

The height is changing appropriately but the y-coord to start rendering from is not being obeyed

@clewis7
Copy link
Member Author

clewis7 commented Feb 20, 2026

Okay, the reason that it is not shifting down is because updates to the layout use the fractional layout to resize, and the rect manager does not take into account x or y offset when doing this

@clewis7 clewis7 marked this pull request as ready for review February 20, 2026 21:28
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/top-gui

@clewis7
Copy link
Member Author

clewis7 commented Feb 22, 2026

@kushalkolar gtg if you can give a review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants