Conversation
Member
|
I'm brain fried I'll review tomorrow or this weekend, but if right and bottom imgui windows still work then it's probably fine, let's worry about left guis when there's a compelling use case? |
kushalkolar
reviewed
Feb 20, 2026
Member
Author
Member
Author
|
Okay, the reason that it is not shifting down is because updates to the layout use the fractional layout to resize, and the rect manager does not take into account x or y offset when doing this |
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/top-gui |
Member
Author
|
@kushalkolar gtg if you can give a review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I thought this would follow the patterns of the other guis (just change the y pos of where pygfx renders to), but the render space does not actually move down unless I manually set the rect
Maybe that is not something that needs to be done for bottom and right but does for a left or top gui
Have enough for the thing I need to do for clepio and can circle back to this
@kushalkolar thoughts welcome since you did the frame/rect manager stuff