feat: Add support for arrays in snowflake#3758
Closed
JohnLemmonMedely wants to merge 5 commits intofeast-dev:masterfrom
Closed
feat: Add support for arrays in snowflake#3758JohnLemmonMedely wants to merge 5 commits intofeast-dev:masterfrom
JohnLemmonMedely wants to merge 5 commits intofeast-dev:masterfrom
Conversation
Contributor
Author
|
@sfc-gh-madkins Here's my draft PR (tests and documentation still pending). I've confirmed it unblocks my specific use-case to support a List[String] and materializing it to a Redis Online store but I'll need to setup the tests to confirm the other paths in the code work. I'd appreciate a sanity check on some of the choices I had to make before I invest more time in this.
|
srausser
reviewed
Sep 13, 2023
Signed-off-by: john.lemmon <john.lemmon@medely.com>
Co-authored-by: Sam Rausser <srausser@gmail.com> Signed-off-by: john.lemmon <john.lemmon@medely.com>
fe8c970 to
fb286f5
Compare
) * fix: Remove unused parameter Signed-off-by: Jiwon Park <bakjeeone@hotmail.com> * feat: Apply cache to load proto registry for performance Signed-off-by: Jiwon Park <bakjeeone@hotmail.com> * fix: Fix update key when cache missed Signed-off-by: phil-park <bakjeeone@hotmail.com> --------- Signed-off-by: Jiwon Park <bakjeeone@hotmail.com> Signed-off-by: phil-park <bakjeeone@hotmail.com>
…st-dev#3761) * resolve feast-dev#3760 Signed-off-by: snowron <snowronark@gmail.com> * format feature_server.py Signed-off-by: snowron <snowronark@gmail.com> --------- Signed-off-by: snowron <snowronark@gmail.com>
…offline store (feast-dev#3762) * Add bigquery table create disposition to offline store Signed-off-by: Nick Zeolla <nick.zeolla@starlingbank.com> * linting Signed-off-by: Nick Zeolla <nick.zeolla@starlingbank.com> --------- Signed-off-by: Nick Zeolla <nick.zeolla@starlingbank.com>
Contributor
Author
|
Closing in favor of #3769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Snowflake doesn't support type-checked arrays but support for arrays can still be added if developers can guarantee the type consistency themselves through the external data pipelines.
Which issue(s) this PR fixes:
Fixes #2280