feat: ES module builds (ESM Support)#2665
Draft
fratzinger wants to merge 37 commits intofeathersjs:dovefrom
Draft
feat: ES module builds (ESM Support)#2665fratzinger wants to merge 37 commits intofeathersjs:dovefrom
fratzinger wants to merge 37 commits intofeathersjs:dovefrom
Conversation
[pull] dove from feathersjs:dove
Feathersjs dove
- add module.exports for default export
Member
|
This looks like a good step, thank you. I am seeing the same error locally you can see in CI:
I'm not sure what that means since all those packages have an identical configuration. |
Open
✅ Deploy Preview for feathers-dove canceled.
|
Member
|
Making a note here that the thing that may be missing is that the ESM and CJS folders each need a { "type": "module|commonjs" }Now that TypeScript seems to support it properly it might also make sense to use full imports with |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request adds ES module builds to all package distributables. It is backwards compatible by still providing the CommonJS version as well but will use ES modules in applications with
"type": "module"(like the generated app) and with client side bundlers so it can use features like tree shaking.Closes #2748
Closes #2001