Fixed and refactored the db.Reference.listen() API#190
Merged
hiranya911 merged 6 commits intomasterfrom Aug 13, 2018
Merged
Conversation
Contributor
Author
|
@the-c0d3r please take a look. |
Contributor
|
@hiranya911 I have looked at the changes. It looks good, much cleaner than what I wrote. But the problem you mentioned in #183 I do not see the problem. But I have been using the SDK with the authentication json file. So that may be obscuring the problem. |
Contributor
Author
|
@the-c0d3r You probably have your database security rules set to public, allowing unauthenticated access to the data. I encountered the issue when testing with a service account json file. |
bjornick
approved these changes
Aug 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #183
KeepAuthSessionnow extends from theAuthorizedSession. This allows thelisten()API to properly authorize outgoing requests.db.Eventtype. The callback gets fired with instances of this class.