Skip to content

chore(deps): Upgrade Lerna to v8#19050

Merged
JPeer264 merged 2 commits intodevelopfrom
jp/update-lerna
Jan 29, 2026
Merged

chore(deps): Upgrade Lerna to v8#19050
JPeer264 merged 2 commits intodevelopfrom
jp/update-lerna

Conversation

@JPeer264
Copy link
Member

@JPeer264 JPeer264 commented Jan 28, 2026

This upgrades Lerna to v8. I this case after the upgrade I followed the upgrade guide and ran lerna repair: https://github.com/lerna/lerna/releases/tag/v8.0.0

Based on the breaking changes we are not affected. The most "critical" one is that Node v16 got dropped, but we are still running the CI in v18.

The "tasksRunnerOptions" were removed, but they are not inline with the other options, so it is easier to configure in the future (this was done automatically with lerna repair)

@JPeer264 JPeer264 requested review from Lms24 and isaacs January 28, 2026 13:21
@JPeer264 JPeer264 self-assigned this Jan 28, 2026
Lms24
Lms24 approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We tried this before (#10835) but I don't recall which issues we ran into. Maybe we can fix them this time :)

@JPeer264
Copy link
Member Author

JPeer264 commented Jan 28, 2026

I think it didn't work as back in the days Node v14+v16 were supported, but lerna v8 doesn't support that (a reason why we can't update to v9 -> it drops Node v18). Lerna was also referenced in the old node-unit-tests.ts file, which has been rewritten now a little:

sentry-javascript/scripts/node-unit-tests.ts

Lines 33 to 47 in 29c856a

'14': {
ignoredPackages: [
'@sentry/solidstart',
'@sentry/sveltekit',
'@sentry/vercel-edge',
'@sentry/astro',
'@sentry/nuxt',
'@sentry/nestjs',
],
legacyDeps: ['lerna@7.1.1', 'nx@16.4.1', '@nx/devkit@16.4.1'],
},
'16': {
ignoredPackages: ['@sentry/vercel-edge', '@sentry/astro'],
legacyDeps: ['lerna@7.1.1', 'nx@16.4.1', '@nx/devkit@16.4.1'],
},

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026 •
edited
Loading

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 25.33 kB - -
@sentry/browser - with treeshaking flags 23.83 kB - -
@sentry/browser (incl. Tracing) 42.14 kB - -
@sentry/browser (incl. Tracing, Profiling) 46.79 kB - -
@sentry/browser (incl. Tracing, Replay) 80.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.41 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 85.47 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 97.66 kB - -
@sentry/browser (incl. Feedback) 42.05 kB - -
@sentry/browser (incl. sendFeedback) 30.02 kB - -
@sentry/browser (incl. FeedbackAsync) 35.01 kB - -
@sentry/browser (incl. Metrics) 26.43 kB - -
@sentry/browser (incl. Logs) 26.58 kB - -
@sentry/browser (incl. Metrics & Logs) 27.25 kB - -
@sentry/react 27.06 kB - -
@sentry/react (incl. Tracing) 44.38 kB - -
@sentry/vue 29.76 kB - -
@sentry/vue (incl. Tracing) 43.94 kB - -
@sentry/svelte 25.34 kB - -
CDN Bundle 27.9 kB - -
CDN Bundle (incl. Tracing) 42.93 kB - -
CDN Bundle (incl. Logs, Metrics) 28.74 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 43.75 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 67.68 kB - -
CDN Bundle (incl. Tracing, Replay) 79.67 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 80.54 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 85.12 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.04 kB - -
CDN Bundle - uncompressed 81.61 kB - -
CDN Bundle (incl. Tracing) - uncompressed 127.16 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 84.45 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 129.99 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 207.83 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 243.76 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 246.58 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.56 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 259.37 kB - -
@sentry/nextjs (client) 46.73 kB - -
@sentry/sveltekit (client) 42.51 kB - -
@sentry/node-core 52.08 kB - -
@sentry/node 166.08 kB - -
@sentry/node - without tracing 93.83 kB - -
@sentry/aws-serverless 109.36 kB - -

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,231 - 9,079 +2%
GET With Sentry 1,650 18% 1,755 -6%
GET With Sentry (error only) 6,050 66% 5,968 +1%
POST Baseline 1,186 - 1,165 +2%
POST With Sentry 588 50% 603 -2%
POST With Sentry (error only) 1,056 89% 1,072 -1%
MYSQL Baseline 3,335 - 3,391 -2%
MYSQL With Sentry 440 13% 513 -14%
MYSQL With Sentry (error only) 2,698 81% 2,754 -2%

View base workflow run

@JPeer264 JPeer264 merged commit acf6c64 into develop Jan 29, 2026
218 checks passed
@JPeer264 JPeer264 deleted the jp/update-lerna branch January 29, 2026 13:07
This was referenced Jan 29, 2026
Open
Merged
This was referenced Jan 30, 2026
Open
Open
This was referenced Jan 30, 2026
Merged
Merged
Open
This was referenced Feb 1, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
This was referenced Feb 4, 2026
Merged
Open
Closed
Open
Open
Open
Open
Open
Merged
Merged
Open
Merged
Merged
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Feb 11, 2026
Merged
1 task
@renovate-bot renovate-bot mentioned this pull request Feb 11, 2026
Merged
1 task
This was referenced Feb 12, 2026
Closed
Merged
Merged
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@isaacs isaacs Awaiting requested review from isaacs

Assignees

@JPeer264 JPeer264

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPeer264 @Lms24