Replace Github authorization endpoint by device authorization grant#496
Replace Github authorization endpoint by device authorization grant#496MichaelMure merged 4 commits intogit-bug:masterfrom
Conversation
MichaelMure
left a comment
There was a problem hiding this comment.
I nitpicked a lot but it's really superficial. Thanks :)
|
I am not really sure why the tests in Travis CI are failing. Is it my error or is it a configuration problem? |
|
In any case, further suggestions for improvements are welcome. |
|
I also would like to ask you about your opinion of the new implementation of |
|
The tests fail because of:
Easy to fix |
Returning a map is not great indeed. You can either make up your own struct with 4 fields to return those values or return 4 values + an error as go allow you to. |
|
I have a question since I am not very familiar with Github: Can I rebase my branch now onto your current master and force-push into my fork? I am wondering if it would create problems in this pull request. |
|
Rebase and |
Co-authored-by: Michael Muré <batolettre@gmail.com>
|
Rebase completed @MichaelMure. |
|
Well, that's awesome, thank you! |
Fix issue #484
Suggestions for changes/improvements are very welcome.