Skip to content

Comments

Webui - Allow to create bugs #158#538

Merged
MichaelMure merged 10 commits intogit-bug:masterfrom
claudioantonio:webui_158
Jan 31, 2021
Merged

Webui - Allow to create bugs #158#538
MichaelMure merged 10 commits intogit-bug:masterfrom
claudioantonio:webui_158

Conversation

@claudioantonio
Copy link
Contributor

No description provided.

- Prettier package update to fix CRLF problem when running on Windows
- Added bt to create new issue and its style (github like)
- layout and style completed
- Component GBButton created
- New issue form partially created (only title)
- Refactoring for GBButon usage

Next steps
- Practice GraphQL calls
- Finish New issue form (add first comment and submit)
- It´s possible to create new issues from webui (only title)

Next step
- Finish new issue form (First comment field and style)
- Update Readme about codegen usage and enforcing playground usage
- Fix for unexpected change in AppBar style when importing Paper

see: mui/material-ui#19157
- It´s possible to create new issue with title and first message from webui
- form simple validation
- Extraction from CommentForm to create a generic component for Comments

Next steps
- Styles
- Readme update about codegen usage and enforcing playground usage
- Fixing github quality code checking issues
@MichaelMure
Copy link
Contributor

Could you make some screenshot of what it looks like?

@MichaelMure MichaelMure requested a review from sandhose January 30, 2021 16:28
Copy link
Contributor

@MichaelMure MichaelMure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from what I know about react, but maybe some part should be more seamless with the rest of the code?

@claudioantonio
Copy link
Contributor Author

For sure!
First screenshot shows the first page where we have all bugs. New issue button was added.
image

When we click on the new issue button then new issue form is presented.
image

Submit new issue only enables when title and message are not empty.
image

After submitting, If You go back to the bug list page You will see the new bug created! 😉
If You click in the recently created bug, You will see its details and will be able to add more comments.
image

Good enough?

@MichaelMure
Copy link
Contributor

Yep, looks good!

- Fix code convention violations
Copy link
Contributor

@MichaelMure MichaelMure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just make sure the linting is fine (make lint and make fix-lint), and you can merge.

@claudioantonio
Copy link
Contributor Author

I ran "npm run lint -- --fix" before the last commit.
I ran the same command now and no warnings neither errors were found.
I don´t have write access to merge the pull request. 😉

@MichaelMure MichaelMure merged commit abd16ff into git-bug:master Jan 31, 2021
@MichaelMure
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants