Webui - Allow to create bugs #158#538
Merged
MichaelMure merged 10 commits intogit-bug:masterfrom Jan 31, 2021
claudioantonio:webui_158
Merged
Webui - Allow to create bugs #158#538MichaelMure merged 10 commits intogit-bug:masterfrom claudioantonio:webui_158
MichaelMure merged 10 commits intogit-bug:masterfrom
claudioantonio:webui_158
Conversation
- Prettier package update to fix CRLF problem when running on Windows
- Added bt to create new issue and its style (github like)
- layout and style completed
- Component GBButton created - New issue form partially created (only title) - Refactoring for GBButon usage Next steps - Practice GraphQL calls - Finish New issue form (add first comment and submit)
- It´s possible to create new issues from webui (only title) Next step - Finish new issue form (First comment field and style) - Update Readme about codegen usage and enforcing playground usage
- Fix for unexpected change in AppBar style when importing Paper see: mui/material-ui#19157
- It´s possible to create new issue with title and first message from webui - form simple validation - Extraction from CommentForm to create a generic component for Comments Next steps - Styles - Readme update about codegen usage and enforcing playground usage
- Fixing github quality code checking issues
Contributor
|
Could you make some screenshot of what it looks like? |
MichaelMure
requested changes
Jan 30, 2021
Contributor
MichaelMure
left a comment
There was a problem hiding this comment.
Looks good from what I know about react, but maybe some part should be more seamless with the rest of the code?
Contributor
Author
Contributor
|
Yep, looks good! |
- Fix code convention violations
MichaelMure
approved these changes
Jan 30, 2021
Contributor
MichaelMure
left a comment
There was a problem hiding this comment.
LGTM!
Just make sure the linting is fine (make lint and make fix-lint), and you can merge.
Contributor
Author
|
I ran "npm run lint -- --fix" before the last commit. |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.