feat: add unarchiving plugin#692
Conversation
|
The unit test is rudimentary. Running locally for many cycles has not caused issues, but more tests or review would be appreciated. |
|
👍 this would be super useful for me |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
lib/plugins/archive.js:3
- The returnValue function should always return an object with both shouldContinue and nopCommands to maintain consistency.
function returnValue(shouldContinue, nop) {
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
|
Hi, I'm not sure if I should open an issue on this, but when trying the release related to this PR, I get a lot of unnecessary calls to repo.change_merge_setting in my use case, I think it's adding empty changes to the repository config |
We shouldn't need to do this soon I hope - github/safe-settings#692
Meant to resolve #443 may help #559
Inspired by #193 I've added a one-off plugin. It is called archive. In most cases it does nothing, but in case a config for archiving a repo is true and the real repo is not archived this plugin will archive that repo and prevent other plugins from running. This does mean config may not be provided to an archived repo, but since it's being archived that hardly matters. This will also clobber the diff comment for PRs where archived is set to true. We may try setting the nop flag to true in the future if the repo is archived by the Archive plugin, but for the purposes of avoiding the rate limit this should be fine.