Merged
Conversation
Signed-off-by: Sebastien Binet <binet@cern.ch>
Signed-off-by: Sebastien Binet <binet@cern.ch>
Member
|
It's not quite true that vet will complain about non-constant formats, it will only complain about this when there is no argument. The fix is valid, but the commit message could be improved. |
Go-1.24's govet will reject fmt.Xprintf calls with a non-constant formatting string and no extra argument. e.g.: `foo(str)` instead of `foo(str, arg1)` Signed-off-by: Sebastien Binet <binet@cern.ch>
Member
Author
|
PTAL (with a somewhat improved commit message wording.) |
Member
Author
|
the Windows failure is known (and we don't care much about it). |
kortschak
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look.