feat: Support timeout as aiohttp.ClientTimeout and total_attempts (max retries) in AsyncAuthorizedSession by yinghsienwu · Pull Request #1961 · googleapis/google-auth-library-python

yinghsienwu · 2026-02-18T18:09:38Z

b/485304839

gemini-code-assist · 2026-02-18T18:09:54Z

Summary of Changes

Hello @yinghsienwu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the AsyncAuthorizedSession by providing more flexible control over network request behavior. It introduces the ability to pass aiohttp.ClientTimeout objects directly for fine-grained timeout configuration and adds a total_attempts parameter to manage the maximum number of retries for a given request. These changes improve the robustness and configurability of asynchronous HTTP operations.

Highlights

Aiohttp ClientTimeout Support: The timeout parameter in AsyncAuthorizedSession and its request methods now accepts an aiohttp.ClientTimeout object, allowing for more granular control over request timeouts beyond a simple float value.
Configurable Total Retries: A new total_attempts parameter has been introduced to the request method, enabling users to specify the maximum number of retry attempts for a given request, enhancing control over retry logic.

Changelog

google/auth/aio/transport/aiohttp.py
- Added typing.Any, typing.Union, and typing imports to support flexible type hints.
- Implemented conditional import and type checking for aiohttp.ClientTimeout to ensure compatibility.
- Modified the timeout parameter in the __call__ method to accept Union[float, ClientTimeout].
- Updated the internal timeout handling logic to directly use an aiohttp.ClientTimeout object if provided.
google/auth/aio/transport/sessions.py
- Added typing.Any, typing.Union, and typing imports for enhanced type hinting.
- Implemented conditional import and type checking for aiohttp.ClientTimeout.
- Modified the timeout parameter in the request, get, post, put, and patch methods to accept Union[float, ClientTimeout].
- Introduced a new total_attempts parameter to the request method, along with updated documentation.
- Updated the AsyncExponentialBackoff initialization to utilize the new total_attempts parameter for retry control.

Activity

No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request enhances AsyncAuthorizedSession by allowing aiohttp.ClientTimeout objects to be passed as timeout and by introducing a total_attempts parameter to configure the maximum number of retries. The changes are well-implemented in the core request method.

However, there are a few areas for improvement:

The convenience methods (get, post, put, patch) have not been updated to accept and pass through the new total_attempts parameter. This makes the new retry functionality unavailable when using these common methods.
The delete method has not been updated at all, and still expects timeout to be a float, and does not support total_attempts. For consistency across the API, it should be updated as well.
There are a couple of minor style issues related to indentation and extra newlines.

I've added specific comments with suggestions to address these points. Overall, this is a valuable addition, and with these adjustments, it will be even better.

google/auth/aio/transport/sessions.py

google/auth/aio/transport/aiohttp.py

google/auth/aio/transport/sessions.py

…x retries) in AsyncAuthorizedSession

…library-python into timeout

google/auth/aio/transport/aiohttp.py

agrawalradhika-cell · 2026-02-18T19:11:51Z

google/auth/aio/transport/sessions.py

@@ -255,10 +271,11 @@ async def delete(
        headers: Optional[Mapping[str, str]] = None,
        max_allowed_time: float = transport._DEFAULT_TIMEOUT_SECONDS,
        timeout: float = transport._DEFAULT_TIMEOUT_SECONDS,


should this not be updated to -Union[float, ClientTimeout] = transport._DEFAULT_TIMEOUT_SECONDS

google/auth/aio/transport/sessions.py

agrawalradhika-cell · 2026-02-18T19:18:15Z

google/auth/aio/transport/aiohttp.py

+if typing.TYPE_CHECKING:
+    from aiohttp import ClientTimeout
+else:
+    ClientTimeout: typing.Type = Any


nit: Using ClientTimeout: typing.Type = Any might be interpreted as ClientTimeout being a class type itself.

maybe we use ClientTimeout = Any or ClientTimeout: Any = Any

agrawalradhika-cell

You will have to fix the build failures before the merge, rest looks good to me!

https://btx.cloud.google.com/invocations/e48f381d-452c-47f9-8977-899068403480/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fgoogle-auth-library-python%2Fpresubmit%2Fsystem-3.10;config=default/log

parthea · 2026-02-20T18:53:33Z

/gemini review

gemini-code-assist

Code Review

The pull request introduces support for aiohttp.ClientTimeout objects and a total_attempts parameter for retries in AsyncAuthorizedSession. The changes are well-implemented, including updated type hints, docstrings, and logic to handle the new parameters. The system tests and unit tests have also been updated to reflect these changes, ensuring proper functionality and coverage. The identified area for improvement, as detailed in the specific comments, is the conditional import logic for ClientTimeout to ensure correct runtime type resolution.

google/auth/aio/transport/aiohttp.py

google/auth/aio/transport/sessions.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

support timeout as aiohttpClientTimeout and total_attempts (max retries)

9693326

yinghsienwu requested review from a team as code owners February 18, 2026 18:09

yinghsienwu changed the title ~~Support timeout as aiohttp.ClientTimeout and total_attempts (max retries) in AsyncAuthorizedSession~~ feat: Support timeout as aiohttp.ClientTimeout and total_attempts (max retries) in AsyncAuthorizedSession Feb 18, 2026

gemini-code-assist bot reviewed Feb 18, 2026

View reviewed changes

google/auth/aio/transport/sessions.py Show resolved Hide resolved

google/auth/aio/transport/aiohttp.py Outdated Show resolved Hide resolved

google/auth/aio/transport/sessions.py Outdated Show resolved Hide resolved

yinghsienwu added 5 commits February 18, 2026 18:17

feat: Support timeout as aiohttp.ClientTimeout and total_attempts (ma…

73a3eb6

…x retries) in AsyncAuthorizedSession

Merge branch 'timeout' of https://github.com/yinghsienwu/google-auth-…

7c1764d

…library-python into timeout

Address lint etc

95ddbf8

Pass total_attempts for other methods

0dabc9b

Merge branch 'main' into timeout

851900d

agrawalradhika-cell reviewed Feb 18, 2026

View reviewed changes

google/auth/aio/transport/aiohttp.py Outdated Show resolved Hide resolved

agrawalradhika-cell reviewed Feb 18, 2026

View reviewed changes

google/auth/aio/transport/sessions.py Show resolved Hide resolved

agrawalradhika-cell reviewed Feb 18, 2026

View reviewed changes

yinghsienwu added 3 commits February 18, 2026 23:03

add tests

19f6ddc

fix mypy

c589d74

fix lint

312f5ad

agrawalradhika-cell approved these changes Feb 19, 2026

View reviewed changes

yinghsienwu added 2 commits February 19, 2026 21:58

fix grpc system test dependency

66a926d

fix grpc system test dependency

2bd10a8

agrawalradhika-cell mentioned this pull request Feb 19, 2026

feat: mTLS configuration via x.509 for asynchronous session in google-auth #1959

Open

parthea approved these changes Feb 20, 2026

View reviewed changes

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

google/auth/aio/transport/aiohttp.py Outdated Show resolved Hide resolved

google/auth/aio/transport/sessions.py Outdated Show resolved Hide resolved

yinghsienwu and others added 3 commits February 20, 2026 11:29

Update google/auth/aio/transport/aiohttp.py

6bbd7ff

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Update google/auth/aio/transport/sessions.py

8261cb4

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

fix lint

4898a03

agrawalradhika-cell merged commit 6aab8bc into googleapis:main Feb 20, 2026
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: Support timeout as aiohttp.ClientTimeout and total_attempts (max retries) in AsyncAuthorizedSession#1961

feat: Support timeout as aiohttp.ClientTimeout and total_attempts (max retries) in AsyncAuthorizedSession#1961
agrawalradhika-cell merged 14 commits intogoogleapis:mainfrom
yinghsienwu:timeout

yinghsienwu commented Feb 18, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 18, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agrawalradhika-cell Feb 18, 2026

Uh oh!

Uh oh!

agrawalradhika-cell Feb 18, 2026

Uh oh!

agrawalradhika-cell left a comment

Uh oh!

parthea commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

yinghsienwu commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 18, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agrawalradhika-cell Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

agrawalradhika-cell Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

agrawalradhika-cell left a comment

Choose a reason for hiding this comment

Uh oh!

parthea commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yinghsienwu commented Feb 18, 2026 •

edited

Loading