Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (855ac89) to head (079bbf1).
⚠️ Report is 4 commits behind head on main.

@@            Coverage Diff             @@
##             main   #15289      +/-   ##
==========================================
- Coverage   92.97%   92.97%   -0.01%     
==========================================
  Files        2402     2402              
  Lines      217949   217996      +47     
==========================================
+ Hits       202641   202679      +38     
- Misses      15308    15317       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Reviewed 10 of 10 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @bajajneha27)

google/cloud/storage/parallel_upload.h line 1210 at r2 (raw file):

    });
  }
  return internal::ClientImplDetails::GetConnection(client)

Consider calling GetConnection before shard creation and save the connection pointer in a local var. This would allow you to continue to std::move(client) when calling CreateParallelUploadShards.

Or, move the shard creation and shard.Upload code to the new ExecuteParallelUploadFile function as well. Ideally, only the code that is dependent on the template parameters should exist in the .h file.

Done.