Skip to content

feat(storage): take async client out of experimental#15573

Merged
bajajneha27 merged 8 commits intogoogleapis:mainfrom
bajajneha27:397946081
Jan 29, 2026
Merged

feat(storage): take async client out of experimental#15573
bajajneha27 merged 8 commits intogoogleapis:mainfrom
bajajneha27:397946081

Conversation

@bajajneha27
Copy link
Contributor

@bajajneha27 bajajneha27 commented Sep 29, 2025 •
edited by scotthart
Loading

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 29, 2025
@codecov
Copy link

codecov bot commented Oct 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.57388% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.96%. Comparing base (fa35817) to head (0dc643b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...le/cloud/storage/examples/storage_async_samples.cc 83.01% 9 Missing ⚠️
...le/cloud/storage/internal/async/connection_impl.cc 87.17% 5 Missing ⚠️
...rage/internal/async/object_descriptor_impl_test.cc 97.29% 1 Missing ⚠️
google/cloud/storage/testing/mock_resume_policy.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15573      +/-   ##
==========================================
- Coverage   92.96%   92.96%   -0.01%     
==========================================
  Files        2460     2460              
  Lines      228931   228901      -30     
==========================================
- Hits       212826   212789      -37     
- Misses      16105    16112       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bajajneha27 bajajneha27 marked this pull request as ready for review October 1, 2025 14:24
@bajajneha27 bajajneha27 requested review from a team as code owners October 1, 2025 14:24
shubham-up-47
shubham-up-47 previously approved these changes Oct 7, 2025
View reviewed changes
shubham-up-47
shubham-up-47 reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@shubham-up-47 shubham-up-47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please search experimental and gcs_ex keywords in your local repo, so that we don't miss these words in any file.

Please fix the code coverage which are affected by these changes.

@bajajneha27 bajajneha27 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 7, 2025
@v-pratap v-pratap self-assigned this Jan 28, 2026
@scotthart
Copy link
Member

scotthart commented Jan 28, 2026

Can we add something to CHANGELOG.md that calls out the promotion of these features from experimental to GA?

@bajajneha27
Copy link
Contributor Author

bajajneha27 commented Jan 29, 2026

Can we add something to CHANGELOG.md that calls out the promotion of these features from experimental to GA?

We can do that when we release this feature. Does that sound okay?

@bajajneha27 bajajneha27 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2026
@bajajneha27 bajajneha27 merged commit 2c1445f into googleapis:main Jan 29, 2026
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scotthart scotthart scotthart approved these changes

@v-pratap v-pratap v-pratap approved these changes

+1 more reviewer

@shubham-up-47 shubham-up-47 shubham-up-47 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@v-pratap v-pratap

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bajajneha27 @scotthart @v-pratap @shubham-up-47