Skip to content

WIP - Investigation of NonNullableValueCoercedAsNullException is being thrown in n MaxQueryDepthInstrumentation #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbakerman wants to merge 1 commit into from
Closed

WIP - Investigation of NonNullableValueCoercedAsNullException is being thrown in n MaxQueryDepthInstrumentation #2763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/test/groovy/graphql/analysis/MaxQueryDepthInstrumentationTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package graphql.analysis

import graphql.ExecutionInput
import graphql.ExecutionResult
import graphql.GraphQL
import graphql.TestUtil
import graphql.execution.AbortExecutionException
import graphql.execution.instrumentation.InstrumentationContext
Expand Down Expand Up @@ -161,4 +163,30 @@ class MaxQueryDepthInstrumentationTest extends Specification {
test == true
notThrown(Exception)
}

def "coercing null variables that are marked as non nullable"() {

given:
def schema = TestUtil.schema("""
type Query {
field(arg : String!) : String
}
""")

MaxQueryDepthInstrumentation maximumQueryDepthInstrumentation = new MaxQueryDepthInstrumentation(6)
def graphQL = GraphQL.newGraphQL(schema).instrumentation(maximumQueryDepthInstrumentation).build()

when:
def query = '''
query x($var : String!) {
field(arg : $var)
}
'''
def executionInput = ExecutionInput.newExecutionInput(query).variables(["var": null]).build()
def er = graphQL.execute(executionInput)

then:
! er.errors.isEmpty()

}
}