Fix AstPrinter to print field descriptions#2808
Merged
bbakerman merged 6 commits intographql-java:masterfrom Apr 27, 2022
Merged
Fix AstPrinter to print field descriptions#2808bbakerman merged 6 commits intographql-java:masterfrom
AstPrinter to print field descriptions#2808bbakerman merged 6 commits intographql-java:masterfrom
Conversation
Member
|
Thanks for this PR fix. I am happy to accept it - but it seems that a test ios failing that might be an assertion on the comment . Can you please have a look |
Contributor
Author
|
@bbakerman Thanks for having a look, i updated the failing test case. |
bbakerman
approved these changes
Apr 27, 2022
| ''' | ||
| } | ||
|
|
||
| def "print empty description"() { |
Member
There was a problem hiding this comment.
Seems there is a test failing IntrospectionResultToSchemaTest > test starwars introspection result FAILED
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AstPrinter.printAstomits field descriptions when there are no arguments or the arguments have no descriptions.To reproduce