Skip to content

Comments

Deprecation time#3768

Merged
dondonz merged 1 commit intomasterfrom
deprecation-time
Dec 8, 2024
Merged

Deprecation time#3768
dondonz merged 1 commit intomasterfrom
deprecation-time

Conversation

@dondonz
Copy link
Member

@dondonz dondonz commented Dec 7, 2024

Cleaning up some methods deprecated for at least 1 year

@dondonz dondonz added this to the 23.x breaking changes milestone Dec 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Test Results

  306 files    306 suites   48s ⏱️
3 480 tests 3 475 ✅ 5 💤 0 ❌
3 569 runs  3 564 ✅ 5 💤 0 ❌

Results for commit 837f60c.

public DataFetcherResult(T data, List<GraphQLError> errors) {
this(data, errors, null, null);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

public GraphQLObjectType getFieldContainer() {
return fieldContainer;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@Deprecated(since = "2023-09-11")
public CompletableFuture<ExecutionResult> getFieldValue() {
return getFieldValueFuture().thenApply(fv -> ExecutionResultImpl.newExecutionResult().data(fv).build());
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@dondonz dondonz merged commit 3888fe8 into master Dec 8, 2024
@dondonz dondonz deleted the deprecation-time branch December 8, 2024 08:03
@dondonz dondonz added the breaking change requires a new major version to be relased label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change requires a new major version to be relased

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants