Commit codeStyle settings#3837
Conversation
|
hi @martinbonnin ... we have already a shared code style that is committed here in the repo: https://github.com/graphql-java/graphql-java/blob/master/graphql-java-code-style.xml |
|
Ah! sorry I missed that. Edit: I've updated that PR to use the already existing code style. Feel free to close if you prefer the current way! No strong opinion here! |
|
In our experience the committed code styles in the .idea folder never really worked consistently and often caused problems over time. For example suddenly it changes it locally without any reason. The import via exported code style worked well, if you import it :-) @bbakerman @dondonz thoughts? |
Agreed, I've seen that too during IJ updates I guess where they introduce new settings or change the defaults, I'm not sure... We haven't seen it in Apollo Kotlin a long time so maybe it's sign things are stabilizing... But maybe not! |
|
And that might seem trivial, but at the end it is very annoying ... this is why we just export/import the code style. Would that work for you for now @martinbonnin ? |
|
Yes of course, closing this. |
Follow up from #3772 (comment)
This is so that IDE configuration is shared between contributors.