bugfix: fix mutations data loading dispatching when defer is enabled#3994
Merged
bugfix: fix mutations data loading dispatching when defer is enabled#3994
Conversation
Contributor
Test Results 312 files 312 suites 53s ⏱️ Results for commit 37aa318. ♻️ This comment has been updated with latest results. |
bbakerman
approved these changes
May 30, 2025
dondonz
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of the mutation data loading #3737 for the case when defer is enabled.
When defer is enabled and dataloading is used for mutations the execution will hang and the dataloader will not be dispatched. Important that defer only needs to be enabled, even when there is no defer used, this bug occurs.
This is a special fix for 24: On master (next release of GJ) we will not have any separate dispatching strategy anymore for defer and this bug doesn't exist.